linux-kernel - Re: [PATCH] firewire: nosy: Replace timeval with timespec64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 22 Mar 2016 15:27:41 +0100
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Tina Ruchandani <ruchandani.tina@...il.com>,
	y2038@...ts.linaro.org, linux1394-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firewire: nosy: Replace timeval with timespec64

On Mar 21 Arnd Bergmann wrote:
>>> On Sunday 20 March 2016 22:59:11 Tina Ruchandani wrote:  
>>>> 'struct timeval' uses a 32 bit field for its 'seconds' value which
>>>> will overflow in year 2038 and beyond. This patch replaces the use
>>>> of timeval in nosy.c with timespec64 which doesn't suffer from y2038
>>>> issue. The code is correct as is - since it is only using the
>>>> microseconds portion of timeval. However, this patch does the
>>>> replacement as part of a larger effort to remove all instances of
>>>> 'struct timeval' from the kernel (that would help identify cases
>>>> where the code is actually broken).
>>>> 
>>>> Signed-off-by: Tina Ruchandani <ruchandani.tina@...il.com>
[...]
> Reviewed-by: Arnd Bergmann <arnd@...db.de>

Committed to linux1394.git.
I will try to get this pulled upstream in the next few days.
-- 
Stefan Richter
-======----- --== =-==-
http://arcgraph.de/sr/