linux-kernel - Re: [PATCH] dlm: config: Fix ENOMEM failures in make

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160322182437.GB6797@lst.de>
Date:	Tue, 22 Mar 2016 19:24:39 +0100
From:	Christoph Hellwig <hch@....de>
To:	Andrew Price <anprice@...hat.com>
Cc:	ccaulfie@...hat.com, teigland@...hat.com, cluster-devel@...hat.com,
	linux-kernel@...r.kernel.org, hch@....de
Subject: Re: [PATCH] dlm: config: Fix ENOMEM failures in make_cluster()

On Tue, Mar 22, 2016 at 05:36:34PM +0000, Andrew Price wrote:
> Commit 1ae1602de0 "configfs: switch ->default groups to a linked list"
> left the NULL gps pointer behind after removing the kcalloc() call which
> made it non-NULL. It also left the !gps check in place so make_cluster()
> now fails with ENOMEM. Remove the remaining uses of the gps variable to
> fix that.
> 
> Reviewed-by: Bob Peterson <rpeterso@...hat.com>
> Reviewed-by: Andreas Gruenbacher <agruenba@...hat.com>
> Signed-off-by: Andrew Price <anprice@...hat.com>

Oops, sorry.  Thanks for fixing this up!