linux-kernel - [PATCH] ASN.1: fix open failure check on headername

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1458685957-13369-1-git-send-email-colin.king@canonical.com>
Date:	Tue, 22 Mar 2016 22:32:37 +0000
From:	Colin King <colin.king@...onical.com>
To:	David Howells <dhowells@...hat.com>,
	David Woodhouse <David.Woodhouse@...el.com>
Cc:	linux-kernel@...r.kernel.org
Subject: [PATCH] ASN.1: fix open failure check on headername

From: Colin Ian King <colin.king@...onical.com>

The check for a failed open on headername is incorrectly checking
on the out FILE pointer rather than the hdr. Fix this.

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 scripts/asn1_compiler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/asn1_compiler.c b/scripts/asn1_compiler.c
index e000f44..c1b7ef3 100644
--- a/scripts/asn1_compiler.c
+++ b/scripts/asn1_compiler.c
@@ -650,7 +650,7 @@ int main(int argc, char **argv)
 	}
 
 	hdr = fopen(headername, "w");
-	if (!out) {
+	if (!hdr) {
 		perror(headername);
 		exit(1);
 	}
-- 
2.7.3