linux-kernel - RE: [PATCH] mpt3sas: Don't overreach ioc->reply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9f49808fa886cafa23b7590114c46b3@mail.gmail.com>
Date:	Wed, 23 Mar 2016 14:43:41 +0530
From:	Chaitra Basappa <chaitra.basappa@...adcom.com>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Calvin Owens <calvinowens@...com>
Cc:	Sathya Prakash <sathya.prakash@...adcom.com>,
	Suganath Prabu Subramani 
	<suganath-prabu.subramani@...adcom.com>,
	"James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
	PDL-MPT-FUSIONLINUX <mpt-fusionlinux.pdl@...adcom.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-team@...com, Sreekanth Reddy <sreekanth.reddy@...adcom.com>
Subject: RE: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during initialization

Hi,
 Please consider this patch as Ack-by: Chaitra P B
<chaitra.basappa@...adcom.com>

Thanks,
 Chaitra

-----Original Message-----
From: Martin K. Petersen [mailto:martin.petersen@...cle.com]
Sent: Tuesday, March 22, 2016 6:00 AM
To: Calvin Owens
Cc: Sathya Prakash; Chaitra P B; Suganath Prabu Subramani; James E.J.
Bottomley; Martin K. Petersen; MPT-FusionLinux.pdl@...adcom.com;
linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org;
kernel-team@...com; Sreekanth Reddy
Subject: Re: [PATCH] mpt3sas: Don't overreach ioc->reply_post[] during
initialization

>>>>> "Calvin" == Calvin Owens <calvinowens@...com> writes:

Calvin> In _base_make_ioc_operational(), we walk ioc->reply_queue_list
Calvin> and pull a pointer out of successive elements of
Calvin> ioc->reply_post[] for each entry in that list if RDPQ is
Calvin> enabled.

Calvin> Since the code pulls the pointer for the next iteration at the
Calvin> bottom of the loop, it triggers the a KASAN dump on the final
Calvin> iteration:

Broadcom folks, please review.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering