linux-kernel - Re: [PATCH] IB/mlx5: fix VFs callback function prototypes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Mar 2016 12:59:11 +0200
From:	Leon Romanovsky <leon@...n.nu>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Doug Ledford <dledford@...hat.com>,
	Matan Barak <matanb@...lanox.com>,
	Leon Romanovsky <leonro@...lanox.com>,
	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	Sagi Grimberg <sagig@...lanox.com>,
	"David S. Miller" <davem@...emloft.net>,
	Haggai Eran <haggaie@...lanox.com>,
	"majd@...lanox.com" <majd@...lanox.com>,
	Saeed Mahameed <saeedm@...lanox.com>,
	Maor Gottlieb <maorg@...lanox.com>,
	Haggai Abramovsky <hagaya@...lanox.com>,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] IB/mlx5: fix VFs callback function prototypes

On Wed, Mar 23, 2016 at 11:37:45AM +0100, Arnd Bergmann wrote:
> The previous patch that added a couple of callback functions put
> the declarations inside of an #ifdef CONFIG_INFINIBAND_ON_DEMAND_PAGING,
> which causes the build to fail if that option is disabled:
> 
> drivers/infiniband/hw/mlx5/main.c: In function 'mlx5_ib_add':
> drivers/infiniband/hw/mlx5/main.c:2358:31: error: 'mlx5_ib_get_vf_config' undeclared (first use in this function)
> 
> This moves the four declarations below the #ifdef section so they
> are always available.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: eff901d30e6c ("IB/mlx5: Implement callbacks for manipulating VFs")

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...lanox.com>