linux-kernel - Re: regmap: mmio: regression in pre-v4.6-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160323113939.GI2566@sirena.org.uk>
Date:	Wed, 23 Mar 2016 11:39:39 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Alexander Stein <alexander.stein@...tec-electronic.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: regmap: mmio: regression in pre-v4.6-rc1

On Wed, Mar 23, 2016 at 12:16:13PM +0100, Alexander Stein wrote:
> On Wednesday 23 March 2016 10:34:15, Mark Brown wrote:

> > Are you *sure* that this is actually big endian?  Are you basing this on
> > documentation or on what happened to work for you in the past.

> Please refer to QorIQ LS1021A Reference Manual (REV 0) table 2.2 (CCSR block 
> base address map) which states that this peripheral (among _most_ but not all) 
> requires byte swapping. Same for DSPI.
> Yeah, it sounds strange.

I don't have that document.

> > Have you tried tracing through the code to see what ends up happening to
> > the I/O?  It should come out using your architecture's big endian
> > accessors.

> In regmap_mmio_gen_context ctx->reg_read is set to regmap_mmio_read32le and 
> ctx->reg_write to regmap_mmio_write32le respectively.

So how does that happen then?  We set these values if the bus is
default, little or native endian but if it's big endian we go into a
completely different case...

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)