linux-kernel - Re: [PATCH 0/2] Change the the config option of mbigen driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <28585531.7OYJ0u0gtH@wuerfel>
Date:	Wed, 23 Mar 2016 13:14:35 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	linux-arm-kernel@...ts.infradead.org
Cc:	MaJun <majun258@...wei.com>, Catalin.Marinas@....com,
	linux-kernel@...r.kernel.org, Will.Deacon@....com,
	mark.rutland@....com, marc.zyngier@....com, jason@...edaemon.net,
	tglx@...utronix.de, lizefan@...wei.com, huxinwei@...wei.com,
	dingtianhong@...wei.com, liguozhu@...ilicon.com,
	guohanjun@...wei.com, zhaojunhua@...ilicon.com
Subject: Re: [PATCH 0/2] Change the the config option of mbigen driver.

On Wednesday 23 March 2016 17:06:31 MaJun wrote:
> From: Ma Jun <majun258@...wei.com>
> 
> In current driver, the config of mbigen driver is a configurable option and
> have nothing to do with CONFIG_ARCH_HISI.
> 
> As a module of Hisilicon SOC, the config of mbigen driver should be selected
> by CONFIG_ARCH_HISI on Hisilicon platform, but not a configurable option.
> 
> This patch set is applied to fix this problem.
> 
> 

I don't understand this one. I thought mbigen is specific to just one
of Hisilicon's SoC families, while ARCH_HISI is more generic and can
also be set for the other ones.

Maybe just add 'default ARCH_HISI' and 'depends on ARCH_HISI || COMPILE_TEST'
to the option? We should certainly keep building this driver for
compile-test on all architectures.

	Arnd