lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Mar 2016 20:03:17 -0400 From: Jessica Yu <jeyu@...hat.com> To: Rusty Russell <rusty@...tcorp.com.au>, Josh Poimboeuf <jpoimboe@...hat.com>, Petr Mladek <pmladek@...e.com>, Jiri Kosina <jikos@...nel.org>, Jonathan Corbet <corbet@....net>, Miroslav Benes <mbenes@...e.cz> Cc: linux-api@...r.kernel.org, live-patching@...r.kernel.org, x86@...nel.org, linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org, linux-doc@...r.kernel.org, Jessica Yu <jeyu@...hat.com> Subject: [PATCH v6 3/5] module: s390: keep mod_arch_specific for livepatch modules Livepatch needs to utilize the symbol information contained in the mod_arch_specific struct in order to be able to call the s390 apply_relocate_add() function to apply relocations. Keep a reference to syminfo if the module is a livepatch module. Remove the redundant vfree() in module_finalize() since module_arch_freeing_init() (which also frees those structures) is called in do_init_module(). If the module isn't a livepatch module, we free the structures in module_arch_freeing_init() as usual. Signed-off-by: Jessica Yu <jeyu@...hat.com> Reviewed-by: Miroslav Benes <mbenes@...e.cz> --- arch/s390/kernel/module.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/s390/kernel/module.c b/arch/s390/kernel/module.c index 7873e17..fbc0789 100644 --- a/arch/s390/kernel/module.c +++ b/arch/s390/kernel/module.c @@ -51,6 +51,10 @@ void *module_alloc(unsigned long size) void module_arch_freeing_init(struct module *mod) { + if (is_livepatch_module(mod) && + mod->state == MODULE_STATE_LIVE) + return; + vfree(mod->arch.syminfo); mod->arch.syminfo = NULL; } @@ -425,7 +429,5 @@ int module_finalize(const Elf_Ehdr *hdr, struct module *me) { jump_label_apply_nops(me); - vfree(me->arch.syminfo); - me->arch.syminfo = NULL; return 0; } -- 2.4.3
Powered by blists - more mailing lists