linux-kernel - Re: [PATCH v4 01/14] i2c-octeon: Cleanup i2c-octeon driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160323195158.GB19849@katana>
Date:	Wed, 23 Mar 2016 20:51:58 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Jan Glauber <jglauber@...ium.com>
Cc:	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	David Daney <ddaney@...iumnetworks.com>
Subject: Re: [PATCH v4 01/14] i2c-octeon: Cleanup i2c-octeon driver

On Fri, Mar 18, 2016 at 09:46:26AM +0100, Jan Glauber wrote:
> Cleanup only without functional change.
> 
> - removed DRV_VERSION
> - defines: use defines instead of plain values,
>   use BIT_ULL macro, add comments
> - rename waitqueue return value to time_left
> - sort local variables by length
> - fix indentation and whitespace errors
> - make function return void if the result is not used
>   (octeon_i2c_stop, octeon_i2c_set_clock)
> - remove debug code from octeon_i2c_stop
> - renamed some functions for readability
> - update copyright
> 
> Signed-off-by: Jan Glauber <jglauber@...ium.com>

Forgot to say: This is already upsteam. Since it is "just" cleanup, I
didn't want to wait another cycle and merged it for v4.6 merge window
already, so we can continue with reviewing the next patches.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)