linux-kernel - Re: [PATCH v4 03/14] i2c-octeon: Change adapter timeout and retry default values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Mar 2016 20:55:18 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Jan Glauber <jglauber@...ium.com>
Cc:	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	David Daney <ddaney@...iumnetworks.com>
Subject: Re: [PATCH v4 03/14] i2c-octeon: Change adapter timeout and retry
 default values

On Fri, Mar 18, 2016 at 09:46:28AM +0100, Jan Glauber wrote:
> Convert the adapter timeout to 2 ms instead of a fixed number of
> jiffies and set retries to 10.

You describe what you change, but not why this is needed. Why 10
retries? And shouldn't that be 20ms seeing the HZ/50 ?

Also, please use "i2c: octeon: " as prefix in the subject.

Thanks,

   Wolfram

> 
> Signed-off-by: Jan Glauber <jglauber@...ium.com>
> ---
>  drivers/i2c/busses/i2c-octeon.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c
> index 9240037..e616e4c 100644
> --- a/drivers/i2c/busses/i2c-octeon.c
> +++ b/drivers/i2c/busses/i2c-octeon.c
> @@ -414,7 +414,6 @@ static struct i2c_adapter octeon_i2c_ops = {
>  	.owner = THIS_MODULE,
>  	.name = "OCTEON adapter",
>  	.algo = &octeon_i2c_algo,
> -	.timeout = HZ / 50,
>  };
>  
>  /* calculate and set clock divisors */
> @@ -541,6 +540,8 @@ static int octeon_i2c_probe(struct platform_device *pdev)
>  	octeon_i2c_set_clock(i2c);
>  
>  	i2c->adap = octeon_i2c_ops;
> +	i2c->adap.timeout = msecs_to_jiffies(2);
> +	i2c->adap.retries = 10;
>  	i2c->adap.dev.parent = &pdev->dev;
>  	i2c->adap.dev.of_node = node;
>  	i2c_set_adapdata(&i2c->adap, i2c);
> -- 
> 1.9.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)