linux-kernel - Re: [PATCH] intel_idle: make intel_idle_state_table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJvTdKnh81ygA_XkL2O1ofTLurfKDPWZWuQXSBVYhr7GLPFLRQ@mail.gmail.com>
Date:	Wed, 23 Mar 2016 16:12:04 -0400
From:	Len Brown <lenb@...nel.org>
To:	Jisheng Zhang <jszhang@...vell.com>
Cc:	Linux PM list <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] intel_idle: make intel_idle_state_table_update() static

Thank you Jisheng, for pointing this out.

your patch conflicts with a patch already in-flight, so I'll not apply
it directly,
but I will fix this problem straight away.

thanks,
Len Brown, Intel Open Source Technology Center

On Tue, Mar 22, 2016 at 10:32 AM, Jisheng Zhang <jszhang@...vell.com> wrote:
> intel_idle_state_table_update() is only used internally in intel_idle,
> so make it static.
>
> Signed-off-by: Jisheng Zhang <jszhang@...vell.com>
> ---
>  drivers/idle/intel_idle.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
> index cd4510a..2e0341e 100644
> --- a/drivers/idle/intel_idle.c
> +++ b/drivers/idle/intel_idle.c
> @@ -1001,7 +1001,7 @@ static void intel_idle_cpuidle_devices_uninit(void)
>   * Currently used to access tuned IVT multi-socket targets
>   * Assumption: num_sockets == (max_package_num + 1)
>   */
> -void intel_idle_state_table_update(void)
> +static void intel_idle_state_table_update(void)
>  {
>         /* IVT uses a different table for 1-2, 3-4, and > 4 sockets */
>         if (boot_cpu_data.x86_model == 0x3e) { /* IVT */
> --
> 2.8.0.rc3
>



-- 
Len Brown, Intel Open Source Technology Center