linux-kernel - Re: [PATCH 5/5] cpufreq: acpi-cpufreq: Clean up hot plug notifier callback.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6345603.OpCxeV2k9k@vostro.rjw.lan>
Date:	Wed, 23 Mar 2016 22:26:45 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Richard Cochran <rcochran@...utronix.de>
Cc:	linux-kernel@...r.kernel.org, rt@...utronix.de,
	Viresh Kumar <viresh.kumar@...aro.org>,
	linux-pm@...r.kernel.org
Subject: Re: [PATCH 5/5] cpufreq: acpi-cpufreq: Clean up hot plug notifier callback.

On Friday, March 18, 2016 10:26:11 PM Richard Cochran wrote:
> This driver has two issues.  First, it tries to fiddle with the hot
> plugged CPU's MSR on the UP_PREPARE event, at a time when the CPU is
> not yet online.  Second, the driver sets the "boost-disable" bit for a
> CPU when going down, but does not clear the bit again if the CPU comes
> up again due to DOWN_FAILED.
> 
> This patch fixes the issues by changing the driver to react to the
> ONLINE/DOWN_FAILED events instead of UP_PREPARE.  As an added benefit,
> the driver also becomes symmetric with respect to the hot plug
> mechanism.
> 
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: Viresh Kumar <viresh.kumar@...aro.org>
> Cc: linux-pm@...r.kernel.org
> Signed-off-by: Richard Cochran <rcochran@...utronix.de>
> ---
>  drivers/cpufreq/acpi-cpufreq.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> index 51eef87..7006a43 100644
> --- a/drivers/cpufreq/acpi-cpufreq.c
> +++ b/drivers/cpufreq/acpi-cpufreq.c
> @@ -540,8 +540,10 @@ static int boost_notify(struct notifier_block *nb, unsigned long action,
>  	 */
>  
>  	switch (action) {
> -	case CPU_UP_PREPARE:
> -	case CPU_UP_PREPARE_FROZEN:
> +	case CPU_DOWN_FAILED:
> +	case CPU_DOWN_FAILED_FROZEN:
> +	case CPU_ONLINE:
> +	case CPU_ONLINE_FROZEN:
>  		boost_set_msrs(acpi_cpufreq_driver.boost_enabled, cpumask);
>  		break;

Applied, thanks!