linux-kernel - Re: [PATCH resend] init/main.c: Simplify initcall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878u187nt0.fsf@rasmusvillemoes.dk>
Date:	Thu, 24 Mar 2016 00:54:35 +0100
From:	Rasmus Villemoes <linux@...musvillemoes.dk>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Oleg Nesterov <oleg@...hat.com>,
	Prarit Bhargava <prarit@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH resend] init/main.c: Simplify initcall_blacklisted()

On Tue, Mar 22 2016, Rusty Russell <rusty@...tcorp.com.au> wrote:

> Rasmus Villemoes <linux@...musvillemoes.dk> writes:
>> Using kasprintf to get the function name makes us look up the name
>> twice, along with all the vsnprintf overhead of parsing the format
>> string etc. It also means there is an allocation failure case to deal
>> with. Since symbol_string in vsprintf.c would anyway allocate an array
>> of size KSYM_SYMBOL_LEN on the stack, that might as well be done up
>> here.
>>
>> Moreover, since this is a debug feature and the blacklisted_initcalls
>> list is usually empty, we might as well test that and thus avoid
>> looking up the symbol name even once in the common case.
>>
>> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
>
> Acked-by: Rusty Russell <rusty@...tcorp.com.au>
>

Thanks. Andrew, can I get you to take it?