linux-kernel - [PATCH] sdcardfs: fix itnull.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1603230820360.2158@localhost6.localdomain6>
Date:	Wed, 23 Mar 2016 08:22:00 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Daniel Rosenberg <drosen@...gle.com>
cc:	Daniel Campello <campello@...gle.com>, kbuild-all@...org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] sdcardfs: fix itnull.cocci warnings

Remove NULL test, as the index variable of list_for-each_entry cannot be 
NULL.

Generated by: scripts/coccinelle/iterators/itnull.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
---

 derived_perm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/sdcardfs/derived_perm.c
+++ b/fs/sdcardfs/derived_perm.c
@@ -112,7 +112,7 @@ void get_derived_permission(struct dentr
 void get_derive_permissions_recursive(struct dentry *parent) {
 	struct dentry *dentry;
 	list_for_each_entry(dentry, &parent->d_subdirs, d_child) {
-		if (dentry && dentry->d_inode) {
+		if (dentry->d_inode) {
 			mutex_lock(&dentry->d_inode->i_mutex);
 			get_derived_permission(parent, dentry);
 			fix_derived_permission(dentry->d_inode);