linux-kernel - Re: [PATCH v3 20/23] atari_scsi: Set a reasonable default for cmd_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56F245B6.2030007@suse.de>
Date:	Wed, 23 Mar 2016 08:28:54 +0100
From:	Hannes Reinecke <hare@...e.de>
To:	Finn Thain <fthain@...egraphics.com.au>,
	"James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
	"Martin K. Petersen" <martin.petersen@...cle.com>,
	Michael Schmitz <schmitzmic@...il.com>,
	linux-m68k@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc:	Ondrej Zary <linux@...nbow-software.org>,
	Sam Creasey <sammy@...my.net>
Subject: Re: [PATCH v3 20/23] atari_scsi: Set a reasonable default for
 cmd_per_lun

On 03/21/2016 03:32 AM, Finn Thain wrote:
> This setting does not need to be conditional on Atari ST or TT.
> 
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
> Tested-by: Michael Schmitz <schmitzmic@...il.com>
> 
> ---
> 
> Changed since v1:
> - Set the default cmd_per_lun to 4 based on test results.
> 
> Changed since v2:
> - Revert the default cmd_per_lun to 2, like in the v1 patch, because
> a uniform default across all ten 5380 wrapper drivers is worth more
> than a tiny improvement in one particular microbenchmark on one system.
> Michael tells me that 2 is also the best setting for his Atari Falcon.
> 
> ---
>  drivers/scsi/atari_scsi.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@...e.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare@...e.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)