linux-kernel - Re: [PATCH 3/5] ftrace perf: Use ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160324104059.GO6356@twins.programming.kicks-ass.net>
Date:	Thu, 24 Mar 2016 11:40:59 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Jiri Olsa <jolsa@...nel.org>, Steven Rostedt <rostedt@...dmis.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: [PATCH 3/5] ftrace perf: Use ftrace_ops::private to store event
 pointer

On Thu, Mar 24, 2016 at 10:47:11AM +0100, Jiri Olsa wrote:
> On Wed, Mar 23, 2016 at 03:26:53PM +0100, Peter Zijlstra wrote:
> > On Wed, Mar 16, 2016 at 03:34:31PM +0100, Jiri Olsa wrote:
> > > Fixing this by using ftrace_ops::private value to keep
> > > the perf_event pointer. This way we don't need to search
> > > for triggered event (as tracepoint handler does) and
> > > directly store sample.
> > 
> > container_of(ops, struct perf_event, ftrace_ops) would also have worked,
> > right?
> 
> yes, I think that would work too

OK, no need to change, I was just seeing if I actually understood the
code.