linux-kernel - Re: [PATCH] mfd: syscon: include errno.h from header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160324110509.GA3496@x1>
Date:	Thu, 24 Mar 2016 11:05:09 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Philipp Zabel <p.zabel@...gutronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: syscon: include errno.h from header

On Wed, 23 Mar 2016, Arnd Bergmann wrote:

> The syscon header uses the ENOTSUPP error constant, but doesn't
> include the header that defines it. This causes a build error
> after the imx pinctrl driver started using syscon:
> 
> include/linux/mfd/syscon.h: In function 'syscon_node_to_regmap':
> include/linux/mfd/syscon.h:32:18: error: 'ENOTSUPP' undeclared (first use in this function)
>   return ERR_PTR(-ENOTSUPP);
>                   ^~~~~~~~
> 
> This adds the missing #include.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Fixes: 8626ada871f1 ("pinctrl: imx: attach iomuxc device to gpr syscon")
> ---
>  include/linux/mfd/syscon.h | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h
> index 1088149be0c9..40a76b97b7ab 100644
> --- a/include/linux/mfd/syscon.h
> +++ b/include/linux/mfd/syscon.h
> @@ -16,6 +16,7 @@
>  #define __LINUX_MFD_SYSCON_H__
>  
>  #include <linux/err.h>
> +#include <linux/errno.h>
>  
>  struct device_node;
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog