linux-kernel - Re: [PATCH v6 0/5] ACPI: parse the SPCR table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Mar 2016 14:16:16 +0100
From:	"Rafael J. Wysocki" <rafael@...nel.org>
To:	Aleksey Makarov <aleksey.makarov@...aro.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J . Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Russell King <linux@....linux.org.uk>,
	Leif Lindholm <leif.lindholm@...aro.org>,
	Graeme Gregory <graeme.gregory@...aro.org>,
	Al Stone <ahs3@...hat.com>,
	Christopher Covington <cov@...eaurora.org>,
	Yury Norov <ynorov@...iumnetworks.com>,
	Peter Hurley <peter@...leysoftware.com>,
	"Zheng, Lv" <lv.zheng@...el.com>
Subject: Re: [PATCH v6 0/5] ACPI: parse the SPCR table

On Thu, Mar 24, 2016 at 1:51 PM, Aleksey Makarov
<aleksey.makarov@...aro.org> wrote:
> 'ARM Server Base Boot Requirements' [1] mentions SPCR (Serial Port
> Console Redirection Table) [2] as a mandatory ACPI table that
> specifies the configuration of serial console.
>
> Move "earlycon" early_param handling to earlycon.c to parse this option once
>
> Patch "ACPI: add definitions of DBG2 subtypes" is required for the next patch.
> ACPI maintainers said that they had got it for the next release of ACPICA,
> but it has not appeared in linux-next yet.

It will.  Patches containing it have just been posted.

> Parse SPCR table, setup earlycon and add register specified console.
>
> Enable parsing this table on ARM64.  Earlycon should be set up
> as early as possible.  ACPI boot tables are mapped in
> arch/arm64/kernel/acpi.c:acpi_boot_table_init() called from setup_arch()
> and that's where we parse spcr.  So it has to be opted-in per-arch.
>
> Implement console_match() for pl011.
>
> Based on the work by Leif Lindholm [3]
> Thanks to Peter Hurley for explaining how this should work.
>
> Should be applied to next-20160324.
>
> Tested on QEMU.  SPCR support is included in QEMU's ARM mach-virt
> since 2.4 release.

Honestly, I'm not sure why I'm regarded as the right maintainer to send this to.

The only patch here touching generic ACPI code is [3/5] (the [2/5] is
going in through ACPICA) and the rest is all about ARM64 AFAICS.  Why
don't you send it to the ARM64 maintainers instead?

I'll have some comments on [3/5], I'll send them later today or tomorrow.

Thanks,
Rafael