linux-kernel - [PATCH 1/1] drm: fsl-dcu: Use flat cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1458826413-3916-1-git-send-email-alexander.stein@systec-electronic.com>
Date:	Thu, 24 Mar 2016 14:33:33 +0100
From:	Alexander Stein <alexander.stein@...tec-electronic.com>
To:	Stefan Agner <stefan@...er.ch>,
	Alison Wang <alison.wang@...escale.com>,
	David Airlie <airlied@...ux.ie>
Cc:	Alexander Stein <alexander.stein@...tec-electronic.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: [PATCH 1/1] drm: fsl-dcu: Use flat cache

Using REGCACHE_RBTREE for MMIO regmap is not valid as spinlock's will be
used during cache allocation.

This fixes the following bug:
BUG: sleeping function called from invalid context at mm/slab.h:388
in_atomic(): 1, irqs_disabled(): 128, pid: 192, name: udevd
[...]

Signed-off-by: Alexander Stein <alexander.stein@...tec-electronic.com>
---
Please refer also to the discussion at
https://lists.freedesktop.org/archives/dri-devel/2016-January/098696.html

 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
index e8d9337..ea65140 100644
--- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
+++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
@@ -40,7 +40,7 @@ static const struct regmap_config fsl_dcu_regmap_config = {
 	.reg_bits = 32,
 	.reg_stride = 4,
 	.val_bits = 32,
-	.cache_type = REGCACHE_RBTREE,
+	.cache_type = REGCACHE_FLAT,
 
 	.volatile_reg = fsl_dcu_drm_is_volatile_reg,
 };
-- 
2.7.3