linux-kernel - Re: [PATCH 08/13] eeprom: at24: call read and write routines via function pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 24 Mar 2016 23:13:54 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:	kbuild-all@...org, Wolfram Sang <wsa@...-dreams.de>,
	linux-i2c <linux-i2c@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Lunn <andrew@...n.ch>,
	Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH 08/13] eeprom: at24: call read and write routines via
 function pointers

Hi Bartosz,

[auto build test WARNING on next-20160324]
[cannot apply to v4.5-rc7 v4.5-rc6 v4.5-rc5 v4.5]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Bartosz-Golaszewski/eeprom-support-for-at24cs-and-at24mac/20160324-230008
config: sparc64-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc64 

All warnings (new ones prefixed by >>):

   drivers/misc/eeprom/at24.c: In function 'at24_probe':
>> drivers/misc/eeprom/at24.c:617:18: warning: assignment from incompatible pointer type
     at24->read_func = at24_read;
                     ^
   drivers/misc/eeprom/at24.c:618:19: warning: assignment from incompatible pointer type
     at24->write_func = at24_write;
                      ^

vim +617 drivers/misc/eeprom/at24.c

   601			num_addresses = 8;
   602		else
   603			num_addresses =	DIV_ROUND_UP(chip.byte_len,
   604				(chip.flags & AT24_FLAG_ADDR16) ? 65536 : 256);
   605	
   606		at24 = devm_kzalloc(&client->dev, sizeof(struct at24_data) +
   607			num_addresses * sizeof(struct i2c_client *), GFP_KERNEL);
   608		if (!at24)
   609			return -ENOMEM;
   610	
   611		mutex_init(&at24->wrbuf_lock);
   612		at24->use_smbus = use_smbus;
   613		at24->use_smbus_write = use_smbus_write;
   614		at24->chip = chip;
   615		at24->num_addresses = num_addresses;
   616	
 > 617		at24->read_func = at24_read;
   618		at24->write_func = at24_write;
   619	
   620		writable = !(chip.flags & AT24_FLAG_READONLY);
   621		if (writable) {
   622			if (!use_smbus || use_smbus_write) {
   623	
   624				unsigned write_max = chip.page_size;
   625	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (45943 bytes)