linux-kernel - Re: [PATCH] mm/page_isolation: fix tracepoint to mirror check function behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56F40CEE.9080201@suse.cz>
Date:	Thu, 24 Mar 2016 16:51:10 +0100
From:	Vlastimil Babka <vbabka@...e.cz>
To:	Lucas Stach <l.stach@...gutronix.de>,
	Joonsoo Kim <js1304@...il.com>, linux-mm@...ck.org
Cc:	linux-kernel@...r.kernel.org, kernel@...gutronix.de,
	patchwork-lst@...gutronix.de
Subject: Re: [PATCH] mm/page_isolation: fix tracepoint to mirror check
 function behavior

On 03/17/2016 06:40 PM, Lucas Stach wrote:
> Page isolation has not failed if the fin pfn extends beyond the end pfn
> and test_pages_isolated checks this correctly. Fix the tracepoint to
> report the same result as the actual check function.

Right.

> Signed-off-by: Lucas Stach <l.stach@...gutronix.de>

Acked-by: Vlastimil Babka <vbabka@...e.cz>

> ---
>   include/trace/events/page_isolation.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/page_isolation.h b/include/trace/events/page_isolation.h
> index 6fb644029c80..8738a78e6bf4 100644
> --- a/include/trace/events/page_isolation.h
> +++ b/include/trace/events/page_isolation.h
> @@ -29,7 +29,7 @@ TRACE_EVENT(test_pages_isolated,
>
>   	TP_printk("start_pfn=0x%lx end_pfn=0x%lx fin_pfn=0x%lx ret=%s",
>   		__entry->start_pfn, __entry->end_pfn, __entry->fin_pfn,
> -		__entry->end_pfn == __entry->fin_pfn ? "success" : "fail")
> +		__entry->end_pfn <= __entry->fin_pfn ? "success" : "fail")
>   );
>
>   #endif /* _TRACE_PAGE_ISOLATION_H */
>