linux-kernel - Re: [PATCH v3] sparc/PCI: Fix for panic while enabling SR-IOV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160324.151654.1707693980081136191.davem@davemloft.net>
Date:	Thu, 24 Mar 2016 15:16:54 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	babu.moger@...cle.com
Cc:	bhelgaas@...gle.com, wangyijing@...wei.com,
	sowmini.varadhan@...cle.com, jiang.liu@...ux.intel.com,
	eric.snowberg@...cle.com, yinghai@...nel.org,
	dan.j.williams@...el.com, sparclinux@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
	ethan.zhao@...cle.com
Subject: Re: [PATCH v3] sparc/PCI: Fix for panic while enabling SR-IOV

From: Babu Moger <babu.moger@...cle.com>
Date: Wed, 23 Mar 2016 15:37:56 -0700

> +#ifdef CONFIG_PCI_IOV
> +int pcibios_add_device(struct pci_dev *dev)
> +{
> +	struct pci_dev *pdev;
> +	/*
> +	 * Add sriov arch specific initialization here.
> +	 * Copy dev_archdata from PF to VF
> +	 */

Always have an empty line after a set of local variable declarations.

Sparc code is to have comments formatted:

	/* Like
	 * this.
	 */

> +		memcpy(&dev->dev.archdata, &pdev->dev.archdata,
> +				sizeof(struct dev_archdata));

Sparc code should indent multi-line expressions by having the second
and subsequent line be indented exactly to the column following the
openning parenthesis on the first line.

You must use the appropriate number of TAB then SPACE characters
necessary to do so.

Thanks.