linux-kernel - Re: Workqueue change with commit id,1bd04bf6f breaks mpt3sas scsi driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160324193914.GC7822@mtj.duckdns.org>
Date:	Thu, 24 Mar 2016 15:39:14 -0400
From:	Tejun Heo <tj@...nel.org>
To:	nick <xerofoify@...il.com>
Cc:	jiangshanlai@...il.com, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: Workqueue change with commit id,1bd04bf6f breaks mpt3sas scsi
 driver

(cc'ing Thomas)

Hello,

On Wed, Mar 23, 2016 at 10:28:16PM -0400, nick wrote:
> Seems that commit id, 1bd04bf6f breaks the mpt3sas driver according to this bug report:
> https://bugzilla.kernel.org/show_bug.cgi?id=114611. Seems that the driver is fine as
> have inspection all the driver functions are wrappers around  queue_delayed_work and
> according to the person's debugging this commit breaks it. However they are not sure
> if it's the driver or the timer subsystem. I am assuming it's the timer subsystem as 
> the driver is just using wrapper functions around core workqueue functions with irqs
> disabled and a spin lock held.

Hmmm... 1bd04bf6f68d ("timer: Remove FIFO "guarantee"") doesn't look
like an easy change to undo and it sounds like the driver was already
(subtly) broken even before the commit given that ordered workqueues
are not affine to any CPU and timer expirations across different CPUs
aren't strictly ordered.  Unfortunately, the only way forward seems to
be implementing ordering from the driver's side.

Thanks.

-- 
tejun