linux-kernel - Re: [PATCH 01/31] bitops: add parity functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160324152815.3489c6d54270f278e5dc7db4@linux-foundation.org>
Date:	Thu, 24 Mar 2016 15:28:15 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Denys Vlasenko <dvlasenk@...hat.com>
Cc:	Zhaoxiu Zeng <zhaoxiu.zeng@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	Martin Kepplinger <martink@...teo.de>,
	Sasha Levin <sasha.levin@...cle.com>,
	Ingo Molnar <mingo@...nel.org>,
	Yury Norov <yury.norov@...il.com>,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH 01/31] bitops: add parity functions

On Thu, 24 Mar 2016 09:38:21 +0100 Denys Vlasenko <dvlasenk@...hat.com> wrote:

> On 03/24/2016 04:03 AM, Zhaoxiu Zeng wrote:
> > +/*
> > + * Type invariant interface to the compile time constant parity functions.
> > + */
> > +#define PARITY(w)    PARITY64((u64)w)
> 
> Can result in incorrect expansion of w. Should be PARITY64((u64)(w))

And we seem to be missing the other 30 patches.