linux-kernel - Re: [PATCH] usb: gadget: fsl_udc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56F51D1D.8020804@cogentembedded.com>
Date:	Fri, 25 Mar 2016 14:12:29 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Dmitry Osipenko <digetx@...il.com>,
	Felipe Balbi <balbi@...nel.org>, Li Yang <leoli@...escale.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Suresh Gupta <suresh.gupta@...escale.com>
Subject: Re: [PATCH] usb: gadget: fsl_udc_core: Fix pullup status

Hello.

On 3/25/2016 2:14 AM, Dmitry Osipenko wrote:

> udc->softconnect should be set regardless of the VBUS state, otherwise
> the USB peripheral device, connected during suspend, won't be detected
> since can_pullup() would return false the UDC controller won't be enabled.
>
> Fixes: 252455c40316 (usb: gadget: fsl driver pullup fix)
> Signed-off-by: Dmitry Osipenko <digetx@...il.com>
> ---
>   drivers/usb/gadget/udc/fsl_udc_core.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c
> index aab5221..118cf7a 100644
> --- a/drivers/usb/gadget/udc/fsl_udc_core.c
> +++ b/drivers/usb/gadget/udc/fsl_udc_core.c
> @@ -1220,10 +1220,11 @@ static int fsl_pullup(struct usb_gadget *gadget, int is_on)
>
>   	udc = container_of(gadget, struct fsl_udc, gadget);
>
> +	udc->softconnect = (is_on != 0);

    !!is_on? Parens not needed anyway though.

> +
>   	if (!udc->vbus_active)
>   		return -EOPNOTSUPP;
>
> -	udc->softconnect = (is_on != 0);
>   	if (can_pullup(udc))
>   		fsl_writel((fsl_readl(&dr_regs->usbcmd) | USB_CMD_RUN_STOP),
>   				&dr_regs->usbcmd);

MBR, Sergei