linux-kernel - Re: [PATCH v2 2/3] phy: rockchip-emmc: should be a child device of the GRF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160325145152.GA32438@rob-hp-laptop>
Date:	Fri, 25 Mar 2016 09:51:52 -0500
From:	Rob Herring <robh@...nel.org>
To:	Heiko Stuebner <heiko@...ech.de>
Cc:	kishon@...com, linux-rockchip@...ts.infradead.org,
	linux-kernel@...r.kernel.org, shawn.lin@...k-chips.com,
	ykk@...k-chips.com, devicetree@...r.kernel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org
Subject: Re: [PATCH v2 2/3] phy: rockchip-emmc: should be a child device of
 the GRF

On Thu, Mar 24, 2016 at 10:29:02PM +0100, Heiko Stuebner wrote:
> The emmc-phy is fully enclosed in the general register files (GRF).
> Therefore as seen from the device-tree it shouldn't be a separate platform-
> device but instead a sub-device of the GRF - using the simply-mfd mechanism.
> 
> The driver entered the kernel in the current merge-window, so we can still
> adapt the binding without needing a fallback, as the binding hasn't been
> released with a full kernel yet.
> 
> Signed-off-by: Heiko Stuebner <heiko@...ech.de>
> ---
> Hi Shawn, Kishon,
> 
> I didn't see this new phy driver until now, so I'd really like to get
> this sorted before the old binding solidifies :-).
> 
> I'll convert the usbphy as well, but that has to have the fallback for
> the old binding, so is not as urgent as these two.
> 
> As mentioned in the patch description above, this is meant as a fixup for
> kernel 4.6.
> 
> 
> changes in v2: drop forgotten rockchip,grf from example
> 
> 
>  .../devicetree/bindings/phy/rockchip-emmc-phy.txt     | 19 ++++++++++++-------
>  drivers/phy/phy-rockchip-emmc.c                       |  5 ++++-
>  2 files changed, 16 insertions(+), 8 deletions(-)

Acked-by: Rob Herring <robh@...nel.org>