linux-kernel - Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Mar 2016 18:58:38 +0200
From:	Felipe Balbi <balbi@...nel.org>
To:	Peter Griffin <peter.griffin@...aro.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	mathias.nyman@...el.com, gregkh@...uxfoundation.org
Cc:	peter.griffin@...aro.org, lee.jones@...aro.org,
	linux-usb@...r.kernel.org, maxime.coquelin@...com,
	patrice.chotard@...com, stable@...r.kernel.org,
	gregory.clement@...e-electrons.com,
	yoshihiro.shimoda.uh@...esas.com
Subject: Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value


Hi,

Peter Griffin <peter.griffin@...aro.org> writes:
> Otherwise generic-xhci and xhci-platform which have no data get wrongly
> detected as XHCI_PLAT_TYPE_MARVELL_ARMADA by xhci_plat_type_is().
>
> This fixes a regression in v4.5 for STiH407 family SoC's which use the
> synopsis dwc3 IP, whereby the disable_clk error path gets taken due to
> wrongly being detected as XHCI_PLAT_TYPE_MARVELL_ARMADA and the hcd never
> gets added.
>
> I suspect this will also fix other dwc3 DT platforms such as Exynos,
> although I've only tested on STih410 SoC.
>
> Fixes: 4efb2f694114 ("usb: host: xhci-plat: add struct xhci_plat_priv")
> Cc: stable@...r.kernel.org
> Cc: gregory.clement@...e-electrons.com
> Cc: yoshihiro.shimoda.uh@...esas.com
> Signed-off-by: Peter Griffin <peter.griffin@...aro.org>
> ---
>  drivers/usb/host/xhci-plat.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-plat.h b/drivers/usb/host/xhci-plat.h
> index 5a2e2e3..529c3c4 100644
> --- a/drivers/usb/host/xhci-plat.h
> +++ b/drivers/usb/host/xhci-plat.h
> @@ -14,7 +14,7 @@
>  #include "xhci.h"	/* for hcd_to_xhci() */
>  
>  enum xhci_plat_type {
> -	XHCI_PLAT_TYPE_MARVELL_ARMADA,
> +	XHCI_PLAT_TYPE_MARVELL_ARMADA = 1,
>  	XHCI_PLAT_TYPE_RENESAS_RCAR_GEN2,
>  	XHCI_PLAT_TYPE_RENESAS_RCAR_GEN3,

aren't these platforms using device tree ? Why aren't these just
different compatible strings ?

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)