linux-kernel - Re: [patch 2/2] drm/exynos: mic: remove some dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 25 Mar 2016 23:09:15 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Inki Dae <inki.dae@...sung.com>
Cc:	Joonyoung Shim <jy0922.shim@...sung.com>,
	Seung-Woo Kim <sw0312.kim@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	David Airlie <airlied@...ux.ie>, Kukjin Kim <kgene@...nel.org>,
	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	dri-devel@...ts.freedesktop.org, linux-samsung-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch 2/2] drm/exynos: mic: remove some dead code

On Fri, Mar 25, 2016 at 05:51:20PM +0900, Inki Dae wrote:
> Hi Dan,
> 
> 2016년 03월 17일 19:39에 Dan Carpenter 이(가) 쓴 글:
> > We know "ret" is zero and the test makes static checkers complain so
> > let's delete this printk.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> > 
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > index 890c9b1..12db353 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > @@ -130,8 +130,6 @@ static void mic_set_path(struct exynos_mic *mic, bool enable)
> >  		val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX);
> >  
> >  	regmap_write(mic->sysreg, DSD_CFG_MUX, val);
> > -	if (ret)
> > -		DRM_ERROR("mic: Failed to read system register\n");
> 
> I think we missed to keep return value from regmap_write function,
> 	ret = regmap_write(mic->sysreg, ....);
> 	if (ret)
> 		...

Yeah.  You're right.

regards,
dan carpenter