linux-kernel - Re: [PATCH 02/17] pinctrl: qcom: ipq4019: fix the function enum for gpio mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160325212259.GB8929@tuxbot>
Date:	Fri, 25 Mar 2016 14:22:59 -0700
From:	Bjorn Andersson <bjorn.andersson@...aro.org>
To:	Matthew McClintock <mmcclint@...eaurora.org>,
	linus.walleij@...aro.org
Cc:	andy.gross@...aro.org, linux-arm-msm@...r.kernel.org,
	qca-upstream.external@....qualcomm.com,
	Rob Herring <robh@...nel.org>,
	Varadarajan Narayanan <varada@...eaurora.org>,
	Mathieu Olivari <mathieu@...eaurora.org>,
	"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 02/17] pinctrl: qcom: ipq4019: fix the function enum for
 gpio mode

On Wed 23 Mar 15:04 PDT 2016, Matthew McClintock wrote:

> Without this, we would fail to set the mode to gpio if trying to
> configure for that mode
> 
> CC: linus.walleij@...aro.org

Linus is the maintainer of the pinctrl subsystem, as such you should
have him as recipient of these patches - so that he doesn't miss them
while being only Cc.

Acked-by: bjorn.andersson@...aro.org

Regards,
Bjorn

> Signed-off-by: Matthew McClintock <mmcclint@...eaurora.org>
> ---
>  drivers/pinctrl/qcom/pinctrl-ipq4019.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-ipq4019.c b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> index cb5f0a8..cb9f16a 100644
> --- a/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> +++ b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> @@ -237,7 +237,7 @@ DECLARE_QCA_GPIO_PINS(99);
>  		.pins = gpio##id##_pins,		\
>  		.npins = (unsigned)ARRAY_SIZE(gpio##id##_pins),	\
>  		.funcs = (int[]){			\
> -			qca_mux_NA, /* gpio mode */	\
> +			qca_mux_gpio, /* gpio mode */	\
>  			qca_mux_##f1,			\
>  			qca_mux_##f2,			\
>  			qca_mux_##f3,			\
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>