linux-kernel - Re: [PATCH] fs/ceph: make logical calculation functions return bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160326003936.GL17997@ZenIV.linux.org.uk>
Date:	Sat, 26 Mar 2016 00:39:36 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Zhang Zhuoyu <zhangzhuoyu@...s.chinamobile.com>
Cc:	"'Yan, Zheng'" <zyan@...hat.com>,
	'Ceph Development' <ceph-devel@...r.kernel.org>,
	'Sage Weil' <sage@...hat.com>, idryomov@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH]  fs/ceph: make logical calculation functions return bool

On Fri, Mar 25, 2016 at 04:42:45PM +0800, Zhang Zhuoyu wrote:
> > This one is for ilookup5.  ilookup5() wants function pointer "int (*test)(struct
> > inode *, void *)”.  The rest change looks good.
> > 
> > Regards
> > Yan, Zheng
> > 
> 
> Yes, you are right, I will send another version.

... as long as that another version does not try to switch the callback type
of ilookup5/iget5_locked/etc argument.