linux-kernel - [PATCH 0/2] scsi: remove orphaned modular code from non-modular drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 27 Mar 2016 13:00:23 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	<linux-kernel@...r.kernel.org>
CC:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	"James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
	<linux-m68k@...r.kernel.org>, <linux-mips@...ux-mips.org>,
	<linux-scsi@...r.kernel.org>
Subject: [PATCH 0/2] scsi: remove orphaned modular code from non-modular drivers

In the ongoing audit/cleanup of non-modular code needlessly using modular
infrastructure, the SCSI subsystem fortunately only contains two instances
that I detected.  Both are for legacy drivers that predate the git epoch,
so cleary there is no demand for converting these drivers to be tristate.

For anyone new to the underlying goal of this cleanup, we are trying to
not use module support for code that isn't buildable as a module since:

 (1) it is easy to accidentally write unused module_exit and remove code
 (2) it can be misleading when reading the source, thinking it can be
     modular when the Makefile and/or Kconfig prohibit it
 (3) it requires the include of the module.h header file which in turn
     includes nearly everything else, thus adding to CPP overhead.
 (4) it gets copied/replicated into other code and spreads like weeds.

Build tested for mips (jazz) and m68k (sun3x) on 4.6-rc1 to ensure no
silly typos crept in.

---

Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>
Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc: linux-m68k@...ts.linux-m68k.org
Cc: linux-mips@...ux-mips.org
Cc: linux-scsi@...r.kernel.org

Paul Gortmaker (2):
  drivers/scsi: make jazz_esp.c driver explicitly non-modular
  drivers/scsi: make sun3x_esp.c driver explicitly non-modular

 drivers/scsi/jazz_esp.c  | 43 ++++++-------------------------------------
 drivers/scsi/sun3x_esp.c | 44 +++++---------------------------------------
 2 files changed, 11 insertions(+), 76 deletions(-)

-- 
2.6.1