linux-kernel - Re: usb: gadget breakage on N900: bind UDC by name passed via usb_gadget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Mar 2016 00:44:27 +0300
From:	Ruslan Bilovol <ruslan.bilovol@...il.com>
To:	Pavel Machek <pavel@....cz>
Cc:	Marek Szyprowski <m.szyprowski@...sung.com>, pali.rohar@...il.com,
	sre@...nel.org, kernel list <linux-kernel@...r.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-omap <linux-omap@...r.kernel.org>,
	Tony Lindgren <tony@...mide.com>, khilman@...nel.org,
	aaro.koskinen@....fi, ivo.g.dimitrov.75@...il.com,
	Patrik Bachan <patrikbachan@...il.com>, serge@...lyn.com,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Peter Chen <peter.chen@...escale.com>,
	Felipe Balbi <balbi@...nel.org>
Subject: Re: usb: gadget breakage on N900: bind UDC by name passed via
 usb_gadget_driver structure

Hi,

On Sun, Mar 27, 2016 at 11:26 PM, Pavel Machek <pavel@....cz> wrote:
> Hi!
>
>> >> I managed to boot N900 with working USB gadget (builtin g_ether)
>> >> in boardfile mode, can ping it from PC and transfer data. I don't
>> >> see any issue (except of musb name issue in twl phy driver, I've
>> >> already sent a fix for that: https://lkml.org/lkml/2016/3/24/670 )
>> >>
>> >> Pavel, I still don't see how you've got your issue, please share
>> >> more detials
>> >
>> > Ok, let me try. I undid all the changes in drivers/phy drivers/usb and
>> > include/linux/usb . I have all the gadget stuff built-in, so that I
>> > could use nfsroot, but this is boot from mmcblk.
>>
>> So do you mean you use original rootfs that was shipeed with N900?
>
> No. I'm using Debian ARM root. It includes useful X and even phone
> functions. https://gitlab.com/tui/tui .
>
>> > gzipped config is attached.
>>
>> Thanks, I'll try that
>
> Thanks.
>
>> > Dmesg from the n900 is attached as /tmp/delme.gz. I did _not_ apply
>> > the patch from https://lkml.org/lkml/2016/3/24/670 , yet, as I'm using
>> > devicetree boot.
>>
>> Hmm.. don't see anything strange in the boot log related to USB,
>> I'll try your config
>
> Let me know how it went.

I tried your config (with slight modifications) with vanilla kernel v4.5
(modifications: cmdline changed to default; used INITRAMFS_SOURCE
for prebuilt cpio archive with rootfs) and Device Tree booting.
Works fine for me except I need to unplug-plug usb cable or issue
# echo connect > /sys/devices/platform/68000000.ocp/480ab000
.usb_otg_hs/musb-hdrc.0.auto/udc/musb-hdrc.0.auto/soft_connect
to make connection.
The gadget driver successfully binds to the gadget, but I don't know
why the musb core doesn't issue pullup on USB lines during boot.

Best regards,
Ruslan