linux-kernel - Re: [RFC PATCH v1 1/9] selftest: sync: basic tests for sw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACvgo532gNFBMOgvxYM_3sJQN4btja3O0mBiirgqbAcZcLyqRQ@mail.gmail.com>
Date:	Mon, 28 Mar 2016 12:56:06 +0100
From:	Emil Velikov <emil.l.velikov@...il.com>
To:	Emilio López <emilio.lopez@...labora.co.uk>
Cc:	Shuah Khan <shuahkh@....samsung.com>, devel@...verdev.osuosl.org,
	Daniel Stone <daniels@...labora.com>,
	Daniel Vetter <daniel.vetter@...ll.ch>,
	Arve Hjønnevåg <arve@...roid.com>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	ML dri-devel <dri-devel@...ts.freedesktop.org>,
	Riley Andrews <riandrews@...roid.com>,
	linux-kselftest@...r.kernel.org,
	Gustavo Padovan <gustavo.padovan@...labora.co.uk>,
	John Harrison <John.C.Harrison@...el.com>
Subject: Re: [RFC PATCH v1 1/9] selftest: sync: basic tests for sw_sync framework

Hi Emilio,

On 9 March 2016 at 15:28, Emilio López <emilio.lopez@...labora.co.uk> wrote:
> These tests are based on the libsync test suite from Android.
> This commit lays the ground for future tests, as well as includes
> tests for a variety of basic allocation commands.
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@...labora.co.uk>
> Signed-off-by: Emilio López <emilio.lopez@...labora.co.uk>
> ---
>

>  tools/testing/selftests/sync/sync.h       | 119 ++++++++++++++++++
Admittedly I know nothing about the kernel selftests although copying
the UAPI header, seems to defeat the purpose of this exercise.
Shouldn't one reuse the existing header ? It would even cause issues
as the interface gets updated (iirc Gustavo changed the ioctl numbers
and/or header name with latter series).

Regards,
Emil