linux-kernel - Re: [PATCH] Staging: iio: Fix sparse endian warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 28 Mar 2016 15:37:54 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Ksenija Stanojevic <ksenija.stanojevic@...il.com>,
	gregkh@...uxfoundation.org
Cc:	Michael.Hennerich@...log.com, knaack.h@....de, pmeerw@...erw.net,
	linux-iio@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: iio: Fix sparse endian warning

On 23/03/16 11:06, Ksenija Stanojevic wrote:
> Fix following sparse warning:
> warning: cast to restricted __be16
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@...il.com>
Subject amended to include the driver name.  I do tend to let some through
without whilst being lazy, but it really should give a hint of the scope
of the patch.  I'll be more vigorous about this in future!

Applied to the togreg branch of iio.git, initially pushed out as staging
for the autobuilders to play with it.

Thanks,

Jonathan
> ---
>  drivers/staging/iio/adc/ad7606_spi.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7606_spi.c b/drivers/staging/iio/adc/ad7606_spi.c
> index d873a51..825da07 100644
> --- a/drivers/staging/iio/adc/ad7606_spi.c
> +++ b/drivers/staging/iio/adc/ad7606_spi.c
> @@ -21,7 +21,8 @@ static int ad7606_spi_read_block(struct device *dev,
>  {
>  	struct spi_device *spi = to_spi_device(dev);
>  	int i, ret;
> -	unsigned short *data = buf;
> +	unsigned short *data;
> +	__be16 *bdata = buf;
>  
>  	ret = spi_read(spi, buf, count * 2);
>  	if (ret < 0) {
> @@ -30,7 +31,7 @@ static int ad7606_spi_read_block(struct device *dev,
>  	}
>  
>  	for (i = 0; i < count; i++)
> -		data[i] = be16_to_cpu(data[i]);
> +		data[i] = be16_to_cpu(bdata[i]);
>  
>  	return 0;
>  }
>