linux-kernel - Re: [PATCH 1/3] perf config: Remove duplicated the code calling set_buildid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Mar 2016 21:52:42 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Taeung Song <treeze.taeung@...il.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	linux-kernel@...r.kernel.org, Jiri Olsa <jolsa@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 1/3] perf config: Remove duplicated the code calling
 set_buildid_dir

On Mon, Mar 28, 2016 at 02:22:18AM +0900, Taeung Song wrote:
> Cc: Jiri Olsa <jolsa@...nel.org>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Signed-off-by: Taeung Song <treeze.taeung@...il.com>

for the patchset:

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka

> ---
>  tools/perf/perf.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/perf/perf.c b/tools/perf/perf.c
> index aaee0a7..7b2df2b 100644
> --- a/tools/perf/perf.c
> +++ b/tools/perf/perf.c
> @@ -549,6 +549,7 @@ int main(int argc, const char **argv)
>  	srandom(time(NULL));
>  
>  	perf_config(perf_default_config, NULL);
> +	set_buildid_dir(NULL);
>  
>  	/* get debugfs/tracefs mount point from /proc/mounts */
>  	tracing_path_mount();
> @@ -572,7 +573,6 @@ int main(int argc, const char **argv)
>  	}
>  	if (!prefixcmp(cmd, "trace")) {
>  #ifdef HAVE_LIBAUDIT_SUPPORT
> -		set_buildid_dir(NULL);
>  		setup_path();
>  		argv[0] = "trace";
>  		return cmd_trace(argc, argv, NULL);
> @@ -587,7 +587,6 @@ int main(int argc, const char **argv)
>  	argc--;
>  	handle_options(&argv, &argc, NULL);
>  	commit_pager_choice();
> -	set_buildid_dir(NULL);
>  
>  	if (argc > 0) {
>  		if (!prefixcmp(argv[0], "--"))
> -- 
> 2.5.0
>