linux-kernel - Re: [PATCH v2 5/6] Documentation: DT: vdma: update binding doc for AXI CDMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Mar 2016 15:55:42 -0500
From:	Rob Herring <robh@...nel.org>
To:	Appana Durga Kedareswara Rao <appana.durga.rao@...inx.com>
Cc:	Soren Brinkmann <sorenb@...inx.com>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	Michal Simek <michals@...inx.com>,
	"vinod.koul@...el.com" <vinod.koul@...el.com>,
	"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
	Anurag Kumar Vulisha <anuragku@...inx.com>,
	"moritz.fischer@...us.com" <moritz.fischer@...us.com>,
	"laurent.pinchart@...asonboard.com" 
	<laurent.pinchart@...asonboard.com>,
	"luis@...ethencourt.com" <luis@...ethencourt.com>,
	Srikanth Vemula <svemula@...inx.com>,
	Anirudha Sarangi <anirudh@...inx.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>
Subject: Re: [PATCH v2 5/6] Documentation: DT: vdma: update binding doc for
 AXI CDMA

On Mon, Mar 28, 2016 at 05:27:01AM +0000, Appana Durga Kedareswara Rao wrote:
> Hi Soren,
> 
> > -----Original Message-----
> > From: Sören Brinkmann [mailto:soren.brinkmann@...inx.com]
> > Sent: Monday, March 28, 2016 12:58 AM
> > To: Appana Durga Kedareswara Rao
> > Cc: robh+dt@...nel.org; pawel.moll@....com; mark.rutland@....com;
> > ijc+devicetree@...lion.org.uk; galak@...eaurora.org; Michal Simek;
> > vinod.koul@...el.com; dan.j.williams@...el.com; Anurag Kumar Vulisha; Appana
> > Durga Kedareswara Rao; moritz.fischer@...us.com;
> > laurent.pinchart@...asonboard.com; luis@...ethencourt.com; Srikanth
> > Vemula; Anirudha Sarangi; devicetree@...r.kernel.org; linux-arm-
> > kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
> > dmaengine@...r.kernel.org
> > Subject: Re: [PATCH v2 5/6] Documentation: DT: vdma: update binding doc for
> > AXI CDMA
> > 
> > On Sun, 2016-03-27 at 23:36:06 +0530, Kedareswara rao Appana wrote:
> > > This patch updates the device-tree binding doc for adding support for
> > > AXI CDMA.
> > >
> > > Signed-off-by: Kedareswara rao Appana <appanad@...inx.com>
> > > ---
> > > ---> Modified commit message as suggested by Vinod.
> > > ---> Moved the patch to forward in the series as suggested by vinod.
> > >
> > >  .../devicetree/bindings/dma/xilinx/xilinx_vdma.txt     | 18
> > +++++++++++++++++-
> > >  1 file changed, 17 insertions(+), 1 deletion(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > index 5841421..2b0c12b 100644
> > > --- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt
> > > @@ -8,8 +8,12 @@ target devices. It can be configured to have one channel
> > or two channels.
> > >  If configured as two channels, one is to transmit to the device and
> > > another  is to receive from the device.
> > >
> > > +Xilinx AXI CDMA engine, it does transfers between memory-mapped
> > > +source address and a memory-mapped destination address.
> > > +
> > >  Required properties:
> > > -- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a"
> > > +- compatible: Should be "xlnx,axi-vdma-1.00.a" or "xlnx,axi-dma-1.00.a" or
> > > +	      "xlnx,axi-cdma-1.00.a""
> > >  - #dma-cells: Should be <1>, see "dmas" property below
> > >  - reg: Should contain VDMA registers location and length.
> > >  - xlnx,num-fstores: Should be the number of framebuffers as configured in
> > h/w.
> > > @@ -80,6 +84,18 @@ axi_dma_0: axidma@...00000 {
> > >  	} ;
> > >  } ;
> > >
> > > +axi_cdma_0: axicdma@...00000 {
> > > +       compatible = "xlnx,axi-cdma-1.00.a";
> > > +       #dma-cells = <1>;
> > > +       reg = < 0x7e200000 0x10000 >;
> > > +       xlnx,addrwidth = <0x20>;
> > > +       dma-channel@...00000 {
> > > +               compatible = "xlnx,axi-dma-mm2s-channel";
> > > +               interrupts = < 0 55 4 >;
> > > +               xlnx,datawidth = <0x40>;
> > > +       } ;
> > > +} ;
> > 
> > As in the other patch, the node name should be 'dma-controller@...' and the
> > inconsistend spacing could be fixed.
> 
> Ok will fix...
> 
> > 
> > Also, it seems this adds pretty much identical examples that just differ in the
> > compat string. Is that really needed?
> 
> Most of the properties are same across the three DMA's
> For AXI VDMA there are few required properties that are not required for AXI DMA/CDMA.
> That's why added example for the other IP's as well I mean for AXI DMA and CDMA.

It needs to be clear what properties are required/valid for each 
compatible string rather than relying on examples. I should be able to 
write or validate the examples based on the rest of the text.

Rob