linux-kernel - Re: [PATCH 1/1] perf tools: Fix build break on powerpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Mar 2016 09:29:59 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
	Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH 1/1] perf tools: Fix build break on powerpc

Hi Arnaldo,

On Mon, 28 Mar 2016 17:52:34 -0300 Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
>
> From: Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>
> 
> Commit 531d2410635c ("perf tools: Do not include stringify.h from the
> kernel sources") seems to have accidentially removed the inclusion of
> "util/header.h" from "arch/powerpc/util/header.c".
> 
> "util/header.h" provides the prototype for get_cpuid() and is needed to
> build perf on Powerpc:
> 
> 	arch/powerpc/util/header.c:17:1: error: no previous prototype for 'get_cpuid' [-Werror=missing-prototypes]
> 
> Reported-by: Michael Ellerman <mpe@...erman.id.au>
> Tested-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> Cc: Stephen Rothwell <sfr@...b.auug.org.au>
> Fixes: 531d2410635c ("perf tools: Do not include stringify.h from the kernel sources")
> Signed-off-by: Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>
> [ Included "util.h" too, to get the scnprintf() prototype ]
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> ---
>  tools/perf/arch/powerpc/util/header.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/arch/powerpc/util/header.c b/tools/perf/arch/powerpc/util/header.c
> index 6138bdef6e63..f8ccee132867 100644
> --- a/tools/perf/arch/powerpc/util/header.c
> +++ b/tools/perf/arch/powerpc/util/header.c
> @@ -4,6 +4,8 @@
>  #include <stdlib.h>
>  #include <string.h>
>  #include <linux/stringify.h>
> +#include "header.h"
> +#include "util.h"
>  
>  #define mfspr(rn)       ({unsigned long rval; \
>  			 asm volatile("mfspr %0," __stringify(rn) \
> -- 
> 2.5.5

Thanks, I will put that in my "fixes" tree until it gets accepted
upstream.

-- 
Cheers,
Stephen Rothwell