| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-id: <1314094711.28841459134703593.JavaMail.weblogic@epmlwas02a>
Date: Mon, 28 Mar 2016 03:11:49 +0000 (GMT)
From: MyungJoo Ham <myungjoo.ham@...sung.com>
To: 최찬우 <cw00.choi@...sung.com>,
박경민 <kyungmin.park@...sung.com>,
크쉬시토프
<k.kozlowski@...sung.com>, "kgene@...nel.org" <kgene@...nel.org>
Cc: "rjw@...ysocki.net" <rjw@...ysocki.net>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
"pawel.moll@....com" <pawel.moll@....com>,
"mark.rutland@....com" <mark.rutland@....com>,
"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
"galak@...eaurora.org" <galak@...eaurora.org>,
"linux@....linux.org.uk" <linux@....linux.org.uk>,
"linux.amoon@...il.com" <linux.amoon@...il.com>,
"m.reichl@...etechno.de" <m.reichl@...etechno.de>,
"tjakobi@...h.uni-bielefeld.de" <tjakobi@...h.uni-bielefeld.de>,
대인기 <inki.dae@...sung.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
"linux-samsung-soc@...r.kernel.org"
<linux-samsung-soc@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v6 06/21] PM / devfreq: Add new passive governor
[]
> Suggested-by: Myungjoo Ham <myungjoo.ham@...sung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
> [tjakobi: Reported RCU locking issue and cw00.choi fix it.]
> Reported-by: Tobias Jakobi <tjakobi@...h.uni-bielefeld.de>
> [m.reichl and linux.amoon: Tested it on exynos4412-odroidu3 board]
> Tested-by: Markus Reichl <m.reichl@...etechno.de>
> Tested-by: Anand Moon <linux.amoon@...il.com>
> ---
> drivers/devfreq/Kconfig | 7 ++
> drivers/devfreq/Makefile | 1 +
> drivers/devfreq/devfreq.c | 17 ++++
> drivers/devfreq/governor.h | 15 +++
> drivers/devfreq/governor_passive.c | 192 +++++++++++++++++++++++++++++++++++++
> include/linux/devfreq.h | 3 +
> 6 files changed, 235 insertions(+)
> create mode 100644 drivers/devfreq/governor_passive.c
>
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
[]
> diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile
> index 8af8aaf922a8..2633087d5c63 100644
> --- a/drivers/devfreq/Makefile
> +++ b/drivers/devfreq/Makefile
> @@ -4,6 +4,7 @@ obj-$(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND) += governor_simpleondemand.o
> obj-$(CONFIG_DEVFREQ_GOV_PERFORMANCE) += governor_performance.o
> obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE) += governor_powersave.o
> obj-$(CONFIG_DEVFREQ_GOV_USERSPACE) += governor_userspace.o
> +obj-$(CONFIG_DEVFREQ_GOV_PASSIVE) += governor_passive.o
>
> # DEVFREQ Drivers
> obj-$(CONFIG_ARM_EXYNOS_BUS_DEVFREQ) += exynos-bus.o
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 1d6c803804d5..9f84bbc2994c 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -478,7 +478,13 @@ static void _remove_devfreq(struct devfreq *devfreq)
> dev_warn(&devfreq->dev, "releasing devfreq which doesn't exist\n");
> return;
> }
> +
> + if (devfreq->governor->type == DEVFREQ_GOV_PASSIVE)
> + devfreq_passive_unregister_notifier(devfreq);
> +
> list_del(&devfreq->node);
> + list_del_init(&devfreq->passive_node);
> +
Let's do this inside governor_passive.c, you already have
the DEVFREQ_GOV_STOP signal. This may be called more frequently
because the START-STOP pair has wider usage than add-remove pair.
However, still, it's ok to be detached during the "STOP"ed but not
removed state.
> mutex_unlock(&devfreq_list_lock);
>
> if (devfreq->governor)
> @@ -598,6 +604,17 @@ struct devfreq *devfreq_add_device(struct device *dev,
> goto err_init;
> }
>
> + if (devfreq->governor->type == DEVFREQ_GOV_PASSIVE) {
> + struct devfreq *parent_devfreq = (struct devfreq *)data;
> + list_add(&devfreq->passive_node, &parent_devfreq->passive_node);
> +
> + err = devfreq_passive_register_notifier(devfreq);
> + if (err <0)
> + goto err_init;
> + } else {
> + INIT_LIST_HEAD(&devfreq->passive_node);
> + }
> +
Same as above. We can reuse DEVFREQ_GOV_START for this.
With DEVFREQ_GOV_START/STOP, we can entirely remove any modifications
in the devfreq.c, governor.h, devfreq.h.
Besides, such an approach removed the need for the patch 05/21.
We no longer (or yet) need "governor type".
> return devfreq;
>
> err_init:
> diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
> index cf19b923c362..64d1dffcdb43 100644
> --- a/drivers/devfreq/governor.h
> +++ b/drivers/devfreq/governor.h
as mentioned above, we don't need to modify this file.
> diff --git a/drivers/devfreq/governor_passive.c b/drivers/devfreq/governor_passive.c
> new file mode 100644
> index 000000000000..521e93b68c11
> --- /dev/null
> +++ b/drivers/devfreq/governor_passive.c
> @@ -0,0 +1,192 @@
> +/*
> + * linux/drivers/devfreq/governor_passive.c
> + *
> + * Copyright (C) 2016 Samsung Electronics
> + * Author: Chanwoo Choi <cw00.choi@...sung.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +#include <linux/devfreq.h>
> +#include <linux/module.h>
> +#include <linux/device.h>
> +#include <linux/devfreq.h>
Doubly included
> +#include "governor.h"
> +
[]
> +static int devfreq_passive_event_handler(struct devfreq *devfreq,
> + unsigned int event, void *data)
> +{
> + return 0;
Let's handle DEVFREQ_GOV_START/STOP event here.
> +}
> +
> +static struct devfreq_governor devfreq_passive = {
> + .name = "passive",
> + .type = DEVFREQ_GOV_PASSIVE,
Let's not use .type enum, yet. We don't this this. At least for now.
> + .get_target_freq = devfreq_passive_get_target_freq,
> + .event_handler = devfreq_passive_event_handler,
> +};
> +
[]
> diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h
As mentioned above, we don't need to modify this file.
Powered by blists - more mailing lists