linux-kernel - Re: [PATCH v6 04/21] PM / devfreq: Add new DEVFREQ_TRANSITION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <56F8A679.5010009@samsung.com>
Date:	Mon, 28 Mar 2016 12:35:21 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	myungjoo.ham@...sung.com,
	박경민 <kyungmin.park@...sung.com>,
	크쉬시토프 <k.kozlowski@...sung.com>,
	"kgene@...nel.org" <kgene@...nel.org>
Cc:	"rjw@...ysocki.net" <rjw@...ysocki.net>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"linux.amoon@...il.com" <linux.amoon@...il.com>,
	"m.reichl@...etechno.de" <m.reichl@...etechno.de>,
	"tjakobi@...h.uni-bielefeld.de" <tjakobi@...h.uni-bielefeld.de>,
	대인기 <inki.dae@...sung.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v6 04/21] PM / devfreq: Add new DEVFREQ_TRANSITION_NOTIFIER
 notifier

On 2016년 03월 28일 11:54, MyungJoo Ham wrote:
>>   
>>  This patch adds the new DEVFREQ_TRANSITION_NOTIFIER notifier to send
>> the notification when the frequency of device is changed.
>> This notifier has two state as following:
>> - DEVFREQ_PRECHANGE  : Notify it before chaning the frequency of device
>> - DEVFREQ_POSTCHANGE : Notify it after changed the frequency of device
>>
>> And this patch adds the resourced-managed function to release the resource
>> automatically when error happen.
>>
>> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>
>> [m.reichl and linux.amoon: Tested it on exynos4412-odroidu3 board]
>> Tested-by: Markus Reichl <m.reichl@...etechno.de>
>> Tested-by: Anand Moon <linux.amoon@...il.com>
>> ---
>>  drivers/devfreq/devfreq.c | 163 +++++++++++++++++++++++++++++++++++++++++++++-
>>  include/linux/devfreq.h   |  58 ++++++++++++++++-
>>  2 files changed, 219 insertions(+), 2 deletions(-)
> 
> []
> 
>> diff --git a/include/linux/devfreq.h b/include/linux/devfreq.h
>> index aa0b8424ebc3..152ea342529c 100644
>> --- a/include/linux/devfreq.h
>> +++ b/include/linux/devfreq.h
>> @@ -19,6 +19,13 @@
>>  
>>  #define DEVFREQ_NAME_LEN 16
>>  
>> +/* DEVFREQ notifier interface */
>> +#define DEVFREQ_TRANSITION_NOTIFIER	(0)
>> +
>> +/* Transition notifiers of DEVFREQ_TRANSITION_NOTIFIER */
>> +#define	DEVFREQ_PRECHANGE		(0)
>> +#define DEVFREQ_POSTCHANGE		(1)
>> +
>>  struct devfreq;
>>  
>>  /**
>> @@ -177,6 +184,13 @@ struct devfreq {
>>  	unsigned int *trans_table;
>>  	unsigned long *time_in_state;
>>  	unsigned long last_stat_updated;
>> +
>> +	struct srcu_notifier_head transition_notifier_list;
>> +};
> 
> Like other properties of struct devfreq, please add
> descriptions above. Other than that, it looks good.

OK. I was missing the description. I'll add it.

Best Regards,
Chanwoo Choi