linux-kernel - Re: [PATCH v2 3/4] regulator: act8865: Pass of_node via act8865_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160328193521.GH2350@sirena.org.uk>
Date:	Mon, 28 Mar 2016 12:35:21 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Maarten ter Huurne <maarten@...ewalker.org>
Cc:	Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/4] regulator: act8865: Pass of_node via
 act8865_regulator_data

On Thu, Mar 17, 2016 at 03:05:07PM +0100, Maarten ter Huurne wrote:
> This makes the code easier to read and it avoids a dynamic memory
> allocation.

Please write better changelogs.  This is a very fiddly and non obvious
set of transformations and it takes far too much effort to work out what
this change does and why it's safe.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)