linux-kernel - Re: [PATCH v2] serial: samsung: Reorder the sequence of clock control when call s3c24xx_serial_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <56FA33A0.4040608@samsung.com>
Date:	Tue, 29 Mar 2016 09:49:52 +0200
From:	Marek Szyprowski <m.szyprowski@...sung.com>
To:	Chanwoo Choi <cw00.choi@...sung.com>, gregkh@...uxfoundation.org,
	jslaby@...e.com
Cc:	k.kozlowski@...sung.com, kgene@...nel.org,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-samsung-soc@...r.kernel.org
Subject: Re: [PATCH v2] serial: samsung: Reorder the sequence of clock control
 when call s3c24xx_serial_set_termios()

Hello,

On 2016-03-28 01:48, Chanwoo Choi wrote:
> This patch fixes the broken serial log when changing the clock source
> of uart device. Before disabling the original clock source, this patch
> enables the new clock source to protect the clock off state for a split second.
>
> Signed-off-by: Chanwoo Choi <cw00.choi@...sung.com>

Reviewed-by: Marek Szyprowski <m.szyprowski@...sung.com>

> ---
> Changes from v1:
> (https://lkml.org/lkml/2016/3/13/183)
> - Enable the clock before changing the source by s3c24xx_serial_setsource()
> - Rebase it on Linux v4.6-rc1
>
>   drivers/tty/serial/samsung.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index ac7f8df54406..99bb23161dd6 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -1271,6 +1271,8 @@ static void s3c24xx_serial_set_termios(struct uart_port *port,
>   	/* check to see if we need  to change clock source */
>   
>   	if (ourport->baudclk != clk) {
> +		clk_prepare_enable(clk);
> +
>   		s3c24xx_serial_setsource(port, clk_sel);
>   
>   		if (!IS_ERR(ourport->baudclk)) {
> @@ -1278,8 +1280,6 @@ static void s3c24xx_serial_set_termios(struct uart_port *port,
>   			ourport->baudclk = ERR_PTR(-EINVAL);
>   		}
>   
> -		clk_prepare_enable(clk);
> -
>   		ourport->baudclk = clk;
>   		ourport->baudclk_rate = clk ? clk_get_rate(clk) : 0;
>   	}

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland