linux-kernel - Re: [PATCH] Staging: comedi: Fix 'unsigned' warning style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <56FA4C95.4030207@mev.co.uk>
Date:	Tue, 29 Mar 2016 10:36:21 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	Aniket Sharma <badbuddha91@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: comedi: Fix 'unsigned' warning style

On 27/03/16 18:52, Aniket Sharma wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> +       unsigned runflags;
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
> +struct comedi_device *comedi_dev_get_from_minor(unsigned minor);
>
> Signed-off-by: Aniket Sharma <badbuddha91@...il.com>
> ---
>   drivers/staging/comedi/comedidev.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedidev.h b/drivers/staging/comedi/comedidev.h
> index 1158072..dcb6376 100644
> --- a/drivers/staging/comedi/comedidev.h
> +++ b/drivers/staging/comedi/comedidev.h
> @@ -173,7 +173,7 @@ struct comedi_subdevice {
>
>   	void *lock;
>   	void *busy;
> -	unsigned runflags;
> +	unsigned int runflags;
>   	spinlock_t spin_lock;	/* generic spin-lock for COMEDI and drivers */
>
>   	unsigned int io_bits;
> @@ -566,7 +566,7 @@ struct comedi_device {
>
>   void comedi_event(struct comedi_device *dev, struct comedi_subdevice *s);
>
> -struct comedi_device *comedi_dev_get_from_minor(unsigned minor);
> +struct comedi_device *comedi_dev_get_from_minor(unsigned int minor);
>   int comedi_dev_put(struct comedi_device *dev);
>
>   bool comedi_is_subdevice_running(struct comedi_subdevice *s);
>

Thanks!

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-