linux-kernel - Re: [PATCH 2/2] mmc: dw_mmc: avoid using dmaengine_terminate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <56F9D82D.4010305@samsung.com>
Date:	Tue, 29 Mar 2016 10:19:41 +0900
From:	Jaehoon Chung <jh80.chung@...sung.com>
To:	Shawn Lin <shawn.lin@...k-chips.com>,
	Ulf Hansson <ulf.hansson@...aro.org>
Cc:	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] mmc: dw_mmc: avoid using dmaengine_terminate_all

Hi Shawn,

Sorry for applying late.
Applied on my repository.

Best Regards,
Jaehoon Chung

On 03/09/2016 11:34 AM, Shawn Lin wrote:
> dmaengine_terminate_all is deprecated and should be
> replaced by more explicit synchronous and asynchronous
> terminate functions. This change is based on the
> commit b36f09c3c441 ("dmaengine: Add transfer termination
> synchronization support"). Currently dw_mci_stop_dma
> may be called under the spinlock, let's migrate
> dmaengine_terminate_all to async terminate. This could
> avoid the race condition of use-after-free resouce of
> dmaengine once slave-dma driver implement the synchronize
> method.
> 
> Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>
> ---
> 
>  drivers/mmc/host/dw_mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 242f9a0..45a406f 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -680,7 +680,7 @@ static const struct dw_mci_dma_ops dw_mci_idmac_ops = {
>  
>  static void dw_mci_edmac_stop_dma(struct dw_mci *host)
>  {
> -	dmaengine_terminate_all(host->dms->ch);
> +	dmaengine_terminate_async(host->dms->ch);
>  }
>  
>  static int dw_mci_edmac_start_dma(struct dw_mci *host,
>