linux-kernel - Re: [PATCH] HID: lenovo: Don't use stack variables for DMA buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1603291539180.3656@cbobk.fhfr.pm>
Date:	Tue, 29 Mar 2016 15:40:54 +0200 (CEST)
From:	Jiri Kosina <jikos@...nel.org>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
cc:	Josh Boyer <jwboyer@...oraproject.org>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: lenovo: Don't use stack variables for DMA buffers

On Tue, 29 Mar 2016, Benjamin Tissoires wrote:

> > The lenovo_send_cmd_cptkbd function uses a stack variable to submit
> > commands via hid_hw_raw_request.  Eventually this gets to the
> > usb_hcd_map_urb_for_dma function, which causes a warning to be thrown
> > if the CONFIG_DMA_API_DEBUG option is enabled.
> > 
> > Fix this by allocating a temporary buffer instead.
> > 
> > Reported-by: lejeczek <peljasz@...oo.co.uk>
> > Signed-off-by: Josh Boyer <jwboyer@...oraproject.org>
> > ---
> 
> The patch is
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> 
> There is just one nitpick that can be solved while committing (or not,
> depending on how Jiri handles it :-P ).

I've nuked the NULL-initialization and applied, thanks!

-- 
Jiri Kosina
SUSE Labs