linux-kernel - Re: [PATCH] perf/core: Fix time tracking bug with multiplexing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Mar 2016 12:43:39 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Stephane Eranian <eranian@...gle.com>,
	linux-kernel@...r.kernel.org, mingo@...e.hu, ak@...ux.intel.com,
	kan.liang@...el.com, jolsa@...hat.com, namhyung@...nel.org,
	vincent.weaver@...ne.edu
Subject: Re: [PATCH] perf/core: Fix time tracking bug with multiplexing

Em Tue, Mar 29, 2016 at 09:26:44AM +0200, Peter Zijlstra escreveu:
> On Tue, Mar 29, 2016 at 03:33:23AM +0200, Stephane Eranian wrote:
> > This patch fixes a bug introduced by:
> > 
> > commit 3cbaa59069677920186dcf502632ca1df4329f80
> > Author: Peter Zijlstra <peterz@...radead.org>
> > Date:   Wed Feb 24 18:45:47 2016 +0100
> > 
> >     perf: Fix ctx time tracking by introducing EVENT_TIME
> 
> Normal quoting style is:
> 
>   3cbaa5906967 ("perf: Fix ctx time tracking by introducing EVENT_TIME")
> 
> I have the following git alias to help with that:
> 
>   one = show -s --pretty='format:%h (\"%s\")'

Cool, for completeness sake:

  $ git config --global alias.one "show -s --pretty='format:%h (\"%s\")'"
  $ git one 3cbaa59069677920186dcf502632ca1df4329f80
  3cbaa5906967 ("perf: Fix ctx time tracking by introducing EVENT_TIME") 

Make sure you have this in place:

  $ git config --global core.abbrev 12

I also have this, FWIW:

  $ cat ~/bin/fixes
  #!/bin/bash

  if [ $# -eq 1 ] ; then
	cset=$1
  else
	read cset
  fi
  git show --pretty=fuller $cset | grep '^\(Author\|Commit\): ' | sed -r 's/.*: +/Cc: /g'
  echo "Fixes: " `git one $cset`
  $ vim ~/bin/fixes 
  $ fixes 3cbaa59069677920186dcf502632ca1df4329f80
  Cc: Peter Zijlstra <peterz@...radead.org>
  Cc: Ingo Molnar <mingo@...nel.org>
  Fixes 3cbaa5906967 ("perf: Fix ctx time tracking by introducing EVENT_TIME")
  $

So that, in vim, I can select the changeset, then do: ":'<,'>!fixes", so
that the author and commiter of the fixed cset gets on the CC list.

- Arnaldo