linux-kernel - Re: [RFC PATCH] acpi: Use a more normal logging style for ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1459267929.25110.80.camel@perches.com>
Date:	Tue, 29 Mar 2016 09:12:09 -0700
From:	Joe Perches <joe@...ches.com>
To:	"Moore, Robert" <robert.moore@...el.com>,
	"Zheng, Lv" <lv.zheng@...el.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	Len Brown <lenb@...nel.org>
Cc:	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"devel@...ica.org" <devel@...ica.org>
Subject: Re: [RFC PATCH] acpi: Use a more normal logging style for
 ACPI_<LEVEL> calls

On Tue, 2016-03-29 at 15:34 +0000, Moore, Robert wrote:
> On the other hand, we removed AE_INFO from ACPI_INFO a while back, and
> this may remove the necessity for the double parens.

Does remove the necessity.

I suppose I could look through the ACPICA sources and generate
the same patch in the ACPICA style.

I didn't manage to run the script that does the style
conversion though.

$ git clone git://github.com/acpica/acpica.git
$ cd acpica
$ make
$

now what?

Removing AE_INFO from ACPI_(WARNING|ERROR) (it seems there
are only a few uses without it and those uses seem
equivalent) is doable too.

For instance:

$ git grep -w ACPI_ERROR|grep -v AE_INFO
[]
source/components/utilities/utobject.c:        ACPI_ERROR ((ModuleName, LineNumber,
source/components/utilities/uttrack.c:        ACPI_ERROR ((Module, Line,
source/components/utilities/uttrack.c:        ACPI_ERROR ((Module, Line,
source/components/utilities/uttrack.c:        ACPI_ERROR ((Module, Line,