linux-kernel - Re: [PATCH] regulator: da9053: regulators is an array, so no need to check if NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160329170133.GU2350@sirena.org.uk>
Date:	Tue, 29 Mar 2016 10:01:33 -0700
From:	Mark Brown <broonie@...nel.org>
To:	Colin King <colin.king@...onical.com>
Cc:	Support Opensource <support.opensource@...semi.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: da9053: regulators is an array, so no need to
 check if NULL

On Mon, Mar 28, 2016 at 04:41:43PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> pdata->regulators is an array, so can never be null, so the
> null check on this array is redundant and can be removed.

What is the value in this change?  The check is always true so it will
be optimised away if the compiler is sensible but leaving it there means
that there's one less thing that can go wrong if the platform data is
changed.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)