linux-kernel - Re: [PATCH] compiler.h: Provide __always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+5PVA5=edrWFVM7xHQiFF3cv6buvihRHLY8enyJ4B8j6iOifA@mail.gmail.com>
Date:	Tue, 29 Mar 2016 14:23:57 -0400
From:	Josh Boyer <jwboyer@...oraproject.org>
To:	Denys Vlasenko <dvlasenk@...hat.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Graf <tgraf@...g.ch>,
	Peter Zijlstra <peterz@...radead.org>,
	David Rientjes <rientjes@...gle.com>,
	Arnd Bergmann <arnd@...db.de>, Ingo Molnar <mingo@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] compiler.h: Provide __always_inline to userspace headers too

On Tue, Mar 29, 2016 at 2:14 PM, Denys Vlasenko <dvlasenk@...hat.com> wrote:
> Recent change to uapi/linux/swab.h needs this.
>
> Signed-off-by: Denys Vlasenko <dvlasenk@...hat.com>
> CC: Josh Boyer <jwboyer@...oraproject.org>
> CC: Thomas Graf <tgraf@...g.ch>
> CC: Peter Zijlstra <peterz@...radead.org>
> CC: David Rientjes <rientjes@...gle.com>
> CC: Arnd Bergmann <arnd@...db.de>
> CC: Ingo Molnar <mingo@...nel.org>
> CC: Andrew Morton <akpm@...ux-foundation.org>
> CC: Linus Torvalds <torvalds@...ux-foundation.org>
> CC: linux-kernel@...r.kernel.org
> ---
>  include/linux/compiler.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/compiler.h b/include/linux/compiler.h
> index b5ff988..2cb6ba4 100644
> --- a/include/linux/compiler.h
> +++ b/include/linux/compiler.h
> @@ -397,12 +397,12 @@ static __always_inline void __write_once_size(volatile void *p, void *res, int s
>   */
>  #define noinline_for_stack noinline
>
> +#endif /* __KERNEL__ */
> +
>  #ifndef __always_inline
>  #define __always_inline inline
>  #endif
>
> -#endif /* __KERNEL__ */
> -

Did you test this by installing the headers with 'make
headers-install' and trying to build something with the newly
installed headers?  As I said in my other email, I don't see how
changes to this particular file are reflected in anything that gets
installed in /usr/include by the uapi mechanism.

josh