linux-kernel - Re: [PATCH] Skein:move macros into appropriate header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20160330010003.GA19630@kroah.com>
Date:	Tue, 29 Mar 2016 18:00:03 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Ming Li <mingli199x@...com>
Cc:	Amitoj Kaur Chawla <amitoj1606@...il.com>,
	Aybuke Ozdemir <aybuke.147@...il.com>,
	Burcin Akalin <brcnakalin@...il.com>,
	Anton Tatuev <tatuev.a.a@...dex.ru>,
	Deepa Dinamani <deepa.kernel@...il.com>,
	devel <devel@...verdev.osuosl.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Skein:move macros into appropriate header files

On Wed, Mar 30, 2016 at 08:51:42AM +0800, Ming Li wrote:
> hi, i move macros into header files.  
> 
> 
> regards,
> 
> 
> Signed-off-by: Ming Li <mingli199x@...com>

That's a very strange changelog comment, can you please expand on what
you are doing this for?

You need to explain _why_ you are doing something, not what you are
doing.

thanks,

greg k-h