[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHp75VcRkwDm60b7PTJmYmPVX7iNoLFL_pcx5qUK8=E7zMyKtw@mail.gmail.com>
Date: Wed, 30 Mar 2016 14:41:29 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: qiujiang <qiujiang@...wei.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Alexandre Courbot <gnurou@...il.com>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Alan Tull <delicious.quinoa@...il.com>,
Jamie Iles <jamie@...ieiles.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
linuxarm@...wei.com, haifeng.wei@...wei.com,
charles.chenxin@...wei.com
Subject: Re: [PATCH v6 2/2] gpio: dwapb: add gpio-signaled acpi event support
On Sat, Mar 26, 2016 at 4:31 AM, qiujiang <qiujiang@...wei.com> wrote:
> This patch adds gpio-signaled acpi event support. It is used for
> power button on hisilicon D02 board, an arm64 platform.
Yes, looks good, my tag stays.
> @@ -502,10 +509,17 @@ dwapb_gpio_get_pdata(struct device *dev)
> }
> }
>
> + if (has_acpi_companion(dev) && pp->idx == 0)
> + pp->irq = platform_get_irq(to_platform_device(dev), 0);
> +
> pp->irq_shared = false;
> pp->gpio_base = -1;
> +
> if (dev->of_node)
> pp->name = to_of_node(fwnode)->full_name;
This change doesn't belong the patch, though it should gone with the
two lines of pp->name assignment as per Alan's suggestion to get rid
of pp->name completely.
> +
> + if (has_acpi_companion(dev))
> + pp->name = acpi_dev_name(to_acpi_device_node(fwnode));
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists